casaroli commented on code in PR #20732: URL: https://github.com/apache/nuttx/pull/20732#discussion_r4304128374
########## libs/libc/pthread/thrd_exit.c: ########## @@ -0,0 +1,55 @@ +/**************************************************************************** + * libs/libc/pthread/thrd_exit.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <pthread.h> +#include <threads.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: thrd_exit + * + * Description: + * Terminate the calling thread. thrd_join() of this thread gets res as + * the result of the thread. + * + * Input Parameters: + * res - The result of the thread + * + * Returned Value: + * This function does not return. + * + ****************************************************************************/ + +void thrd_exit(int res) Review Comment: **C11 7.26.5.5** defines `thrd_exit()` as a library function. In threads.h it was a static inline function, so a program could not take its address, and `#pragma weak thrd_exit` failed with "weak declaration of 'thrd_exit' must be public". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
