xiaoxiang781216 commented on code in PR #20762: URL: https://github.com/apache/nuttx/pull/20762#discussion_r4305570670
########## include/nuttx/fs/fs.h: ########## @@ -106,9 +106,11 @@ * * Bit 0-3: Inode type (Bit 3 indicates internal OS types) * Bit 4: Set if inode has been unlinked and is pending removal. + * Bit 5: Set if a mount point was mounted with MS_NOEXEC. */ #define FSNODEFLAG_TYPE_MASK 0x0000000f /* Isolates type field */ +#define FSNODEFLAG_NOEXEC 0x00000020 /* Mounted with MS_NOEXEC */ Review Comment: move after line 126 ########## include/nuttx/fs/fs.h: ########## @@ -139,6 +141,7 @@ #define INODE_IS_PIPE(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_PIPE) #define INODE_IS_NAMEDEVENT(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_NAMEDEVENT) #define INODE_IS_HARDLINK(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_HARDLINK) +#define INODE_IS_NOEXEC(i) (((i)->i_flags & FSNODEFLAG_NOEXEC) != 0) Review Comment: move after line 166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
