xiaoxiang781216 commented on code in PR #20764: URL: https://github.com/apache/nuttx/pull/20764#discussion_r4306051119
########## binfmt/builtin.c: ########## @@ -115,11 +115,13 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->gid = builtin->gid; binp->mode = builtin->mode; - chk = binfmt_checkexecperm(binp); +# ifdef CONFIG_BINFMT_CHECKEXEC + chk = binfmt_checkexecperm(binp->mode, binp->uid, binp->gid); Review Comment: why can't reuse the common check in load_absmodule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
