casaroli opened a new pull request, #3877: URL: https://github.com/apache/nuttx-apps/pull/3877
## Summary apache/nuttx#20778 adds `popen()`, `pclose()`, `dpopen()` and `dpclose()` to libc; they are built when `CONFIG_PIPES`, `CONFIG_LIBC_EXECFUNCS` and `CONFIG_SCHED_WAITPID` are set. The apps users of `popen()` only accept the copy in `system/popen`: the fastboot shell command, the popen test and the popen example depend on `CONFIG_SYSTEM_POPEN`, and dhcpd and gdbstub use `popen()` only with it. This PR lets these five users take either copy. It is the first step to remove `system/popen`; then the defconfigs move to the libc copy, `system/popen` is removed, and the libc guard goes. The first commit only fixes old nxstyle errors in `system/gdbstub/gdbstub.c`. depends-on: apache/nuttx/pull/20778 ## Impact A configuration that disables `CONFIG_SYSTEM_POPEN` keeps the fastboot shell command, the popen test and example, and the `popen()` code of dhcpd and gdbstub. Configurations that enable `CONFIG_SYSTEM_POPEN` do not change. ## Testing With apache/nuttx#20778 and the defconfig PR (CONFIG_SYSTEM_POPEN disabled, so only the libc copy is built): | Configuration | Result | |---|---| | `qemu-armv8a:nsh` + `CONFIG_TESTING_POPEN`, `popen_test` in QEMU | `=== Results: 0 failed ===` (popen and dpopen, 7 tests) | | `qemu-armv8a:fastboot` | builds; `CONFIG_SYSTEM_FASTBOOTD_SHELL=y` kept; libc `lib_popen.o`/`lib_dpopen.o` built, no `system/popen` object | | `lx_cpu:nsh`, `sabre-6quad:citest` | build; `CONFIG_EXAMPLES_POPEN=y` kept in `sabre-6quad:citest` | Without them (nuttx master, `CONFIG_SYSTEM_POPEN=y`): `qemu-armv8a:fastboot` builds with the apps copy and keeps `CONFIG_SYSTEM_FASTBOOTD_SHELL=y`. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
