casaroli opened a new pull request, #3883:
URL: https://github.com/apache/nuttx-apps/pull/3883
## Summary
With `CONFIG_EXAMPLES_HELLO=m`, the Make build makes `hello` a loadable
module (`MODULE = $(CONFIG_EXAMPLES_HELLO)` in the Makefile).
`examples/hello/CMakeLists.txt` does not give `MODULE` to
`nuttx_add_application()`, so the CMake build makes no program at all: `hello`
is not built in, and there is no `bin/hello` (`nsh: hello: command not found`).
This PR gives `MODULE ${CONFIG_EXAMPLES_HELLO}` to both
`nuttx_add_application()` calls, as the other examples do.
## Impact
CMake builds with `CONFIG_EXAMPLES_HELLO=m`: `bin/hello` is now a loadable
module. No change for `y`.
## Testing
`qemu-armv8a:nsh` (flat, CMake, QEMU HVF) with `CONFIG_ELF`,
`CONFIG_EXECFUNCS_SYSTEM_SYMTAB` and `CONFIG_EXAMPLES_HELLO=m`, `bin/` loaded
from a 9p share:
| | master | this PR |
|---|---|---|
| `bin/hello` | not built; `nsh: hello: command not found` | built; `Hello,
World!!` |
The test needs apache/nuttx#20807 (`get_environ_ptr` in libc.csv) to load
any ELF program with the system symbol table.
`tools/checkpatch.sh -c -u -m -g` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
