xiaoxiang781216 commented on code in PR #20787: URL: https://github.com/apache/nuttx/pull/20787#discussion_r4316298675
########## tools/ci/testlist/arm-imxrt.dat: ########## @@ -0,0 +1,11 @@ +/arm/imxrt,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/imx6,CONFIG_ARM_TOOLCHAIN_GNU_EABI Review Comment: why not name arm_imx.dat ########## tools/ci/testlist/arm-stm32f0-f3.dat: ########## @@ -0,0 +1,76 @@ +/arm/stm32f0,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/stm32f1,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/stm32f2,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/stm32f3,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/stm32f1/nucleo-f1*,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f2/nucleo-f2*,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f3/nucleo-f33*,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/olimexino-stm32,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/shenzhou,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/stm3210e-eval,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/stm32_tiny,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/stm32butterfly2,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f3/stm32f334-disco,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f3/stm32f3discovery,CONFIG_ARM_TOOLCHAIN_CLANG +/arm/stm32f1/stm32vldiscovery,CONFIG_ARM_TOOLCHAIN_CLANG Review Comment: let's keep the sort in all files ########## tools/ci/testlist/arm-rp2040.dat: ########## @@ -0,0 +1,8 @@ +/arm/rp2040,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/rp23xx,CONFIG_ARM_TOOLCHAIN_GNU_EABI Review Comment: why not name arm-rp2xxx.dat ########## tools/ci/testlist/arm-ti-cxd56.dat: ########## @@ -0,0 +1,8 @@ +/arm/cxd56xx,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/rm57,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/tiva,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/tms570,CONFIG_ARM_TOOLCHAIN_GNU_EABI Review Comment: arm-ti.dat ########## tools/ci/testlist/arm-nrf.dat: ########## @@ -1,41 +1,24 @@ -/arm/max326xx/*,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/moxart/*,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/mps/mps2*,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/nrf52,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/nrf53,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/nrf54l,CONFIG_ARM_TOOLCHAIN_GNU_EABI +/arm/nrf91,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/mps/mps3-an547/configs/ap,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/mps/mps3-an547/configs/bl,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/mps/mps3-an547/configs/clang,CONFIG_ARM_TOOLCHAIN_CLANG -/arm/mps/mps3-an547/configs/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI -/arm/mps/mps3-an547/configs/picostest,CONFIG_ARM_TOOLCHAIN_GNU_EABI - -/arm/mx8mp/*,CONFIG_ARM_TOOLCHAIN_GNU_EABI - -/arm/[n-q]*,CONFIG_ARM_TOOLCHAIN_GNU_EABI - --moxa:nsh # Boards build by CMake CMake,arduino-nano-33ble:nsh CMake,arduino-nano-33ble:usbnsh Review Comment: move to other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
