casaroli commented on code in PR #20813: URL: https://github.com/apache/nuttx/pull/20813#discussion_r4334291034
########## libs/libc/libc.csv: ########## @@ -1,6 +1,12 @@ "__assert","assert.h","","void","FAR const char *","int","FAR const char *" "__cxa_atexit","stdlib.h","","int","FAR CODE void (*)(FAR void *)|FAR void *","FAR void *","FAR void *" "__errno","errno.h","defined(CONFIG_BUILD_FLAT)","FAR int *" +"__gcov_dump","gcov.h","defined(CONFIG_COVERAGE_MINI) && defined(CONFIG_ARCH_TOOLCHAIN_GCC)","void" Review Comment: OK, in a later PR. ########## tools/Config.mk: ########## @@ -70,6 +70,23 @@ MODULECC ?= $(CC) MODULELD ?= $(LD) MODULESTRIP ?= $(STRIP) +# A loadable module of a flat or protected build can use the coverage +# functions of the image only with CONFIG_COVERAGE_MINI and GCC. Otherwise +# the arch Toolchain.defs adds these options to the module options, so that +# a module and its crt0 are built without the coverage of CONFIG_COVERAGE_ALL. + +ifeq ($(CONFIG_COVERAGE_ALL),y) Review Comment: Do you mean: remove the `-fno-` coverage options from this PR, so it only adds module coverage for `CONFIG_COVERAGE_MINI` with GCC, and modules with libgcov or clang coverage stay unlinkable until that later PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
