Brijesh-Thakkar commented on code in PR #20842: URL: https://github.com/apache/nuttx/pull/20842#discussion_r4337488953
########## drivers/serial/uart_16550.c: ########## @@ -53,6 +53,19 @@ * Pre-processor Definitions ****************************************************************************/ +/* Optional per-port hooks. Without CONFIG_16550_PORT_HOOKS every port has + * an interrupt and the default attach/detach, which lets the compiler drop + * the code that handles the hooks. + */ + +#ifdef CONFIG_16550_PORT_HOOKS Review Comment: Measured (GCC 15.2, whole image): without this option the pt adds +128 B on qemu-intel64:nsh and +372 B on qemu-i486:nsh; with it +32 B and +160 B, so it saves ~96-212 B. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
