xiaoxiang781216 commented on code in PR #20711:
URL: https://github.com/apache/nuttx/pull/20711#discussion_r4343669633
##########
cmake/nuttx_add_application.cmake:
##########
@@ -234,11 +234,15 @@ function(nuttx_add_application)
set_property(TARGET ${TARGET}
PROPERTY ELF_BINARY ${CMAKE_CURRENT_BINARY_DIR}/${TARGET})
+ if(NOT DYNLIB_ELF_MODE)
+ set_property(TARGET ${TARGET} PROPERTY ELF_APP TRUE)
+ endif()
+
nuttx_add_library_internal(${TARGET})
# loadable build requires applying ELF flags to all applications
- if(CONFIG_MODULES)
+ if(CONFIG_MODULES AND NOT DYNLIB_ELF_MODE)
Review Comment:
why check DYNLIB_ELF_MODE
##########
cmake/nuttx_add_application.cmake:
##########
Review Comment:
why not update NUTTX_ELF_APP_COMPILE_OPTIONS directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
