Swatantra-66 commented on code in PR #20874:
URL: https://github.com/apache/nuttx/pull/20874#discussion_r4348213633
##########
arch/arm/src/cmake/Toolchain.cmake:
##########
@@ -43,7 +43,13 @@ else() # ARM9, ARM7TDMI, etc.
set(ARCH_SUBDIR arm)
endif()
-include(${ARCH_SUBDIR})
+if(ARCH_SUBDIR)
Review Comment:
Removed the if(ARCH_SUBDIR) and if(EXISTS ...) checks. Since default values
are set in the preceding else() branch and the files are guaranteed to be
present in the directory, we now directly include
${CMAKE_CURRENT_LIST_DIR}/${ARCH_SUBDIR}.cmake and
${CMAKE_CURRENT_LIST_DIR}/${TOOLCHAIN_FILE}.cmake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
