acassis commented on code in PR #20853: URL: https://github.com/apache/nuttx/pull/20853#discussion_r4348339288
########## sched/task/task_setup.c: ########## @@ -45,6 +45,16 @@ #include "group/group.h" #include "task/task.h" +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#if CONFIG_TASK_MAX_ARGS < 4 +# define NXTASK_ARG_LEN_CACHE_SIZE CONFIG_TASK_MAX_ARGS +#else +# define NXTASK_ARG_LEN_CACHE_SIZE 4 +#endif Review Comment: @anchao why not this way: ``` #if CONFIG_TASK_MAX_ARGS >= 4 # define NXTASK_ARG_LEN_CACHE_SIZE 4 #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
