CV-Bowen opened a new pull request, #20899:
URL: https://github.com/apache/nuttx/pull/20899
## Summary
rptun cleanups from static analysis, plus one real fix:
- check the result of remoteproc_mmap() in rptun_update_vring_da(); on
failure vring_da was undefined but still written to the vring and the
shared memory pointer advanced past it
- initialize vdev in rptun_create_device() (GCC maybe-uninitialized)
- MISRA/Coverity: unsigned constants in unsigned comparisons, 0 instead
of NULL for function pointers, ops tables defined in the function that
uses them, size_t / unsigned int for vring size and device index
- remove include/nuttx/rptun/openamp.h, which nothing includes
The first commit only fixes existing nxstyle errors in rptun.c.
## Impact
- `include/nuttx/rptun/openamp.h` is removed (unused).
- `rptun_dev_reset()` takes `int` like the public `reset` op; no public
API or Kconfig change.
## Testing
Host: Ubuntu 22.04.5 LTS x86_64, QEMU version 10.2.1, sim: cc (Ubuntu
13.1.0-8ubuntu1~22.04) 13.1.0, qemu-armv8a: aarch64-none-elf-gcc (Arm GNU
Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1 20221205
Both baseline configurations start the remote through rptun
(sim_rptun on sim, rptun_ivshmem on qemu-armv8a), create the virtio
devices and map their vrings, so `rpmsg dump all` / `rpmsg ping all`
below cover the changed paths.
Baseline (`test.sh`, cases: baseline.yaml):
- host: Ubuntu 22.04.5 LTS x86_64, QEMU version 10.2.1, sim: cc (Ubuntu
13.1.0-8ubuntu1~22.04) 13.1.0, qemu-armv8a: aarch64-none-elf-gcc (Arm GNU
Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1 20221205
- tested: nuttx 33dac7abce9 apps ea8addeaf
- qemu-armv8a built with test-only overlay: disabled LIBC_ENVPATH
BINFMT_CHECKEXEC
- sim:rpserver + sim:rpproxy: PASS
- [x] `uname -a` (server)
- [x] `rpmsg dump all` (server)
- [x] `rpmsg ping all 10 1024 3 0` (server)
- [x] `uname -a` (proxy)
- [x] `rpmsg ping all 10 1024 3 0` (proxy)
- [x] `mount -t rpmsgfs -o cpu=server,fs=/proc /sp` (proxy)
- [x] `cat /sp/version` (proxy)
- [x] `rpmsg dump all` (proxy)
- qemu-armv8a:rpserver + qemu-armv8a:rpproxy: PASS
- [x] `uname -a` (server)
- [x] `uname -a` (proxy)
- [x] `rpmsg dump all` (server)
- [x] `rpmsg ping all 10 1024 3 0` (server)
- [x] `rpmsg ping all 10 1024 3 0` (proxy)
- [x] `mount -t rpmsgfs -o cpu=server,fs=/proc /sp` (proxy)
- [x] `cat /sp/version` (proxy)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
