xiaoxiang781216 commented on code in PR #3904: URL: https://github.com/apache/nuttx-apps/pull/3904#discussion_r4358546576
########## netutils/ping/icmp_ping.c: ########## @@ -56,6 +56,11 @@ #define ICMP_IOBUFFER_SIZE(x) (sizeof(struct icmp_hdr_s) + (x)) #define ICMP_SET_FILTER(t) (~(1U << (t))) +/* A difference of two clock() values in microseconds and milliseconds */ + +#define CLOCK2USEC(clk) ((clk) * USEC_PER_SEC / CLOCKS_PER_SEC) +#define CLOCK2MSEC(clk) ((clk) * MSEC_PER_SEC / CLOCKS_PER_SEC) Review Comment: ditto ########## netutils/dhcpc/dhcpc.c: ########## @@ -65,6 +65,10 @@ /* Configuration */ +/* A difference of two clock() values in milliseconds */ + +#define CLOCK2MSEC(clk) ((clk) * MSEC_PER_SEC / CLOCKS_PER_SEC) Review Comment: why not keep in nuttx/include/nuttx/clock.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
