michallenc commented on code in PR #20938: URL: https://github.com/apache/nuttx/pull/20938#discussion_r4363732909
########## drivers/can/can.c: ########## @@ -96,6 +96,10 @@ #define CAN_CLOSE_DRAIN_LOOPS 20u /* 20 * 500 ms = 10 s per stage */ +/* Data length of a classic CAN frame with DLC 8..15 */ + +#define CAN_CLASSIC_MAXDATALEN 8 Review Comment: ditto ########## drivers/can/kvaser_pci.c: ########## @@ -53,6 +54,7 @@ /* Kvaser card constants */ #define KVASER_SJA_MAX 4 +#define KVASER_CLASSIC_MAXDATALEN 8 Review Comment: ditto ########## drivers/can/ctucanfd_pci.c: ########## @@ -60,6 +60,10 @@ #define CTUCANFD_CTUCAN_REGS 0x4000 +/* Data bytes of a classic CAN frame with DLC 8..15 */ + +#define CTUCANFD_CLASSIC_MAXDATALEN 8 Review Comment: You can use `CAN_MAX_DLEN` defined in `include/nuttx/can.h` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
