xiaoxiang781216 opened a new pull request, #20960: URL: https://github.com/apache/nuttx/pull/20960
## Summary Remove the stale REVISIT `#warning` from `max3421e_enumerate()`. The apostrophe in its unquoted text is parsed as an unterminated character literal. With `-Werror`, this fails the build even when preprocessor warnings are disabled. This fixes the `stm32f103-minimum/usbhost` build failure observed in apache/nuttx#20938: https://github.com/apache/nuttx/actions/runs/40071853385/job/120807219487?pr=20938 No dependencies or companion NuttX Apps changes are required. ## Impact Build-only fix for the MAX3421E USB host driver. Removes two lines without changing executable code, runtime behavior, public interfaces, or configuration. ## Testing Host: Linux. Compiler: `arm-none-eabi-gcc 13.2.1 20231009`. Original CI failure (`stm32f103-minimum/usbhost`): ```text usbhost/usbhost_max3421e.c:3606:23: error: missing terminating ' character [-Werror] 3606 | #warning REVISIT: Isn't this already done? cc1: all warnings being treated as errors ``` Locally reproduced the diagnostic by passing the original directive to: ```text arm-none-eabi-gcc -Werror -Wno-cpp -x c -fsyntax-only - <stdin>:1:23: error: missing terminating ' character [-Werror] cc1: all warnings being treated as errors ``` After removing the directive, the same focused compiler check exits with status 0. This is a preprocessor diagnostic check, not a full driver or board build. Validation on the upstream-based fix branch: ```text git diff --check: PASS git diff | tools/checkpatch.sh -: All checks pass. ``` No full board build or hardware runtime test was performed. This change removes only a diagnostic directive; upstream CI must verify the complete board build. ## Contribution status AI assistance is disclosed in the commit's `Assisted-by` and `Co-authored-by` trailers. The commit currently has no `Signed-off-by`: NuttX requires that certification to be added by a human contributor, so human sign-off remains outstanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
