This is an automated email from the ASF dual-hosted git repository.
xiaoxiang781216 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a40089b95bb drivers/usbhost: Remove stale MAX3421E enumeration warning.
a40089b95bb is described below
commit a40089b95bb5d5db8d295f17c2c5e3fc40d86436
Author: Xiang Xiao <[email protected]>
AuthorDate: Sat Oct 24 18:59:01 2026 +0800
drivers/usbhost: Remove stale MAX3421E enumeration warning.
Remove the REVISIT preprocessor warning in max3421e_enumerate(). Its
unquoted apostrophe is diagnosed as a missing terminating character literal,
which becomes a build error under -Werror even when preprocessor warnings are
disabled.
This fixes the stm32f103-minimum/usbhost CI failure reported in
apache/nuttx#20938 without changing runtime behavior.
Validated with git diff --check and tools/checkpatch.sh. Reproduced the
original diagnostic with arm-none-eabi-gcc 13.2.1 on Linux; the removed
directive no longer produces the diagnostic. No full board build or hardware
runtime test was performed.
Assisted-by: Copilot SDK in VS Code
Signed-off-by: Xiang Xiao <[email protected]>
---
drivers/usbhost/usbhost_max3421e.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usbhost/usbhost_max3421e.c
b/drivers/usbhost/usbhost_max3421e.c
index ea33b694d2d..022c4428f56 100644
--- a/drivers/usbhost/usbhost_max3421e.c
+++ b/drivers/usbhost/usbhost_max3421e.c
@@ -3603,8 +3603,6 @@ static int max3421e_enumerate(FAR struct
usbhost_connection_s *conn,
max3421e_lock(priv);
-#warning REVISIT: Isn't this already done?
-
#ifdef CONFIG_USBHOST_HUB
if (ROOTHUB(hport))
#endif
