daniel-p-carvalho opened a new pull request, #3912:
URL: https://github.com/apache/nuttx-apps/pull/3912

   ## Summary
   
   * `wifibridge_start()` only tore down what it had done when it failed after 
the bridge was created. A failure before that, for example an Ethernet port 
that cannot be brought up, left the SoftAP running with no bridge. Every 
failure now goes through the same teardown, which already tolerates steps that 
were never done.
   * `wifibridge status` now also reports whether a configuration is saved 
(SSID, channel and security, never the passphrase) when 
`NETUTILS_WIFIBRIDGE_PERSIST` is enabled: `saved none`, `saved ssid "Foo" 
channel 11 WPA2` or `saved unreadable (<err>)`.
   
   ## Impact
   
   Only `netutils/wifibridge` and `system/wifibridge`. No Kconfig or API 
change. The `status` output gains one line.
   
   ## Testing
   
   EV49N51A (`ev49n51a:bridge`, PIC32MZ-W1), cable not connected at boot: 
`eth0` fails to come up, the log shows `AP started`, `AP stopped` and `Failed 
to start the bridge`, and the SoftAP is no longer left running. `save -s Foo -p 
foopass123 -c 11`, `status` and `clear` show `saved ssid "Foo" channel 11 WPA2` 
and then `saved none`.
   
   sim:nsh with the wifibridge options: `status` shows `saved none`, then the 
saved values after `save`. `tools/checkpatch.sh` passes.
   
   The start path with the cable connected is not changed and was not retested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to