acassis commented on PR #3920: URL: https://github.com/apache/nuttx-apps/pull/3920#issuecomment-6417662075
> Yes Here is a quick outline > > Fast-fail check in CI - Run early in `.github/workflows/check.yml` (before the heavy matrix builds spin up). Detection Logic - Check `git diff` against the base ref (`origin/master...HEAD`). If a `Makefile` or `Make.defs` in a directory is created or modified, verify that `CMakeLists.txt` in that same directory (or parent component) is also created/modified. Bypass mechanism - If a PR has a label (e.g., `ci:make-only`) or a commit message tag (e.g., `[skip-cmake-check]`), allow it to pass so legitimate Make-only bug fixes aren't blocked. > > @acassis, would you prefer this integrated as a new option in `tools/checkpatch.sh` (so contributors can also test it locally with `./tools/checkpatch.sh -g HEAD~1..HEAD`), or as a dedicated step in `.github/workflows/check.yml`? @Swatantra-66 I think only a check in checkpatch.sh should be enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
