xiaoxiang781216 commented on code in PR #20996:
URL: https://github.com/apache/nuttx/pull/20996#discussion_r4384499281
##########
sched/Kconfig:
##########
@@ -1646,8 +1646,8 @@ config ENABLE_PARTIAL_SIGNALS
config DISABLE_ALL_SIGNALS
bool "Disable all signal support"
+ depends on DISABLE_MQUEUE_NOTIFICATION
select DISABLE_POSIX_TIMERS
Review Comment:
change to dependence too
##########
include/nuttx/lib/math32.h:
##########
@@ -319,25 +319,23 @@ extern "C"
while (0)
#if defined(__GNUC__)
Review Comment:
why check `__GNUC__` in the common code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
