xiaoxiang781216 commented on code in PR #20686: URL: https://github.com/apache/nuttx/pull/20686#discussion_r4385477907
########## include/nuttx/net/bluetooth/addr.h: ########## @@ -0,0 +1,444 @@ +/**************************************************************************** + * include/nuttx/net/bluetooth/addr.h + * + * Ported to Apache NuttX by chao an <[email protected]>. Review Comment: remove company copyright ########## drivers/wireless/bluetooth/bt_driver.c: ########## @@ -96,6 +100,10 @@ int bt_driver_register_with_id(FAR struct bt_driver_s *driver, int id) } #endif +#ifdef CONFIG_BT + return bt_hci_driver_register_btdev(driver); Review Comment: bt_netdev_register ########## libs/zblue/CMakeLists.txt: ########## @@ -0,0 +1,40 @@ +# ############################################################################## +# libs/zblue/CMakeLists.txt Review Comment: I still prefer zblue belong nuttx-apps.git, @raiden00pl what's your opinion? ########## boards/sim/sim/sim/src/sim_bringup.c: ########## @@ -434,6 +434,19 @@ int sim_bringup(void) } #endif +#ifdef CONFIG_BT + /* Run NuttX Bluetooth compatibility initializers after the simulated + * board-level Bluetooth HCI drivers have had a chance to register + * themselves. + */ + + ret = bt_sys_init_run(); Review Comment: why not hook bluetooth_initialize ########## include/nuttx/atomic.h: ########## Review Comment: why dup include/nuttx/atomic.h ########## net/Kconfig: ########## @@ -438,6 +438,7 @@ source "net/netlink/Kconfig" source "net/tcp/Kconfig" source "net/udp/Kconfig" source "net/bluetooth/Kconfig" + Review Comment: revert ########## mm/net_buf/CMakeLists.txt: ########## @@ -0,0 +1,29 @@ +# ############################################################################## +# mm/net_buf/CMakeLists.txt Review Comment: move to bluetooth subsystem ########## include/nuttx/mm/net_buf.h: ########## @@ -0,0 +1,848 @@ +/**************************************************************************** + * include/nuttx/mm/net_buf.h + * + * Author: chao an <[email protected]> + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_MM_NET_BUF_H +#define __INCLUDE_NUTTX_MM_NET_BUF_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stddef.h> +#include <stdint.h> +#include <stdbool.h> +#include <nuttx/list.h> +#include <nuttx/spinlock.h> +#include <nuttx/semaphore.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Alignment for buffer definitions */ + +#if CONFIG_NET_BUF_ALIGNMENT == 0 +# define __net_buf_align __attribute__((aligned(sizeof(void *)))) +#else +# define __net_buf_align \ + __attribute__((aligned(CONFIG_NET_BUF_ALIGNMENT))) +#endif + +/* Flag indicating external data ownership */ + +#define NET_BUF_EXTERNAL_DATA (1 << 0) + +/**************************************************************************** + * Public Type Definitions + ****************************************************************************/ + +/** + * Simple network buffer representation. + * + * This is a simpler variant of the net_buf object (in fact net_buf uses + * net_buf_simple internally). It doesn't provide any kind of reference + * counting, user data, dynamic allocation, or in general the ability to + * pass through kernel objects such as FIFOs. + */ + +struct net_buf_simple Review Comment: move to bluetooth since no other subsystem will use it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
