casaroli commented on code in PR #21042: URL: https://github.com/apache/nuttx/pull/21042#discussion_r4392392786
########## arch/tricore/include/irq.h: ########## @@ -156,62 +72,157 @@ #define FPU_TRAP_FZE_SHIFT 20 #define FPU_TRAP_TCL_SHIFT 1 +/* MPU CSFR numbers for TRICORE_MFCR/MTCR (TC1.6.2P/TC1.8 core arch manuals). Review Comment: About 120 MPU CSFR macros go into the public `arch/irq.h`, which every application includes; only `tricore_mpu.c` and `tricore_mpu.h` use them. Fix: move the block to `arch/tricore/src/common/tricore_mpu.h`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
