casaroli opened a new pull request, #21054: URL: https://github.com/apache/nuttx/pull/21054
## Summary `struct spifi_driver_s` in `arch/arm/src/lpc43xx/hardware/lpc43_spifi.h` describes the function table of the SPIFI driver in the LPC43xx boot ROM. Three of its names mix upper and lower case (`checkAd`, `setProt` and the `intLen` parameter of `cmd`), which the coding standard does not allow, so nxstyle reports them and checkpatch fails for every change that touches this header. This PR renames them to `check_ad`, `set_prot` and `intlen`. ## Impact None at run time. Nothing uses these names, and the table must match the ROM only in the order and the types of its members. ## Testing nxstyle on the header: 3 x "Mixed case identifier found" on master, no finding with this PR. `lpc4337-ws:nsh` (`CONFIG_LPC43_SPIFI=y`, so `lpc43_spifi.c` includes this header) builds; its only warning is the `#warning "Missing Logic"` of `lpc43_allocateheap.c` that master has too. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
