Fix-Point commented on code in PR #21001: URL: https://github.com/apache/nuttx/pull/21001#discussion_r4396189768
########## sched/wdog/wdog.h: ########## @@ -176,11 +179,9 @@ static inline_function void wd_timer_start(clock_t tick, bool in_expiration) #ifdef CONFIG_SCHED_TICKLESS_ALARM up_alarm_tick_start(next_tick); #else - clock_t now = clock_systime_ticks(); - - /* A passed deadline must fire now: timers may read the delay unsigned */ - - up_timer_tick_start(clock_compare(next_tick, now) ? 0 : next_tick - now); + clock_t now = clock_systime_ticks(); + clock_t delay = clock_compare(now, next_tick) ? next_tick - now : 0; Review Comment: A fix has already been applied here; I would like to ensure the code style is consistent with the rest of the code in `wdog.h`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
