Swatantra-66 commented on code in PR #21047: URL: https://github.com/apache/nuttx/pull/21047#discussion_r4405540406
########## drivers/serial/serial.c: ########## @@ -177,10 +181,12 @@ static const struct file_operations g_serialops = NULL, /* mmap */ NULL, /* truncate */ uart_poll, /* poll */ +#ifdef CONFIG_FS_UIO Review Comment: right, We should not build `serial.*` when `CONFIG_SERIAL` is disabled. Furthermore, CodeRabbit noted, guarding `readv`/`writev` in `struct file_operations` and `struct mountpt_operations` causes positional initializers across multiple filesystems (e.g. `tmpfs`, `fat`, `littlefs`) to shift callbacks when `CONFIG_FS_UIO` is disabled. I have updated this PR to focus directly on the root issue: gating `drivers/serial/` compilation on `CONFIG_SERIAL` in both `Make.defs` and `CMakeLists.txt` and dropping the struct changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
