xiaoxiang781216 commented on code in PR #21064:
URL: https://github.com/apache/nuttx/pull/21064#discussion_r4397798373
##########
drivers/misc/rwbuffer.c:
##########
@@ -357,7 +380,12 @@ static ssize_t rwb_writebuffer(FAR struct rwbuffer_s *rwb,
padblocks = startblock % rwb->wralignblocks;
rwb->wrblockstart = startblock - padblocks;
rwb->wrnblocks = padblocks;
- rwb_read_(rwb, rwb->wrblockstart, padblocks, rwb->wrbuffer);
+ ret = rwb_read_(rwb, rwb->wrblockstart, padblocks, rwb->wrbuffer);
+ if (ret < 0 || (size_t)ret != padblocks)
Review Comment:
remove the cast
##########
drivers/misc/rwbuffer.c:
##########
@@ -151,9 +151,20 @@ static void rwb_wrflush(FAR struct rwbuffer_s *rwb)
padblocks = rwb->wrnblocks % rwb->wralignblocks;
if (padblocks)
{
+ ssize_t nread;
+
padblocks = rwb->wralignblocks - padblocks;
- rwb_read_(rwb, rwb->wrblockstart + rwb->wrnblocks, padblocks,
- &rwb->wrbuffer[rwb->wrnblocks * rwb->blocksize]);
+ nread = rwb_read_(rwb, rwb->wrblockstart + rwb->wrnblocks,
+ padblocks,
+ &rwb->wrbuffer[rwb->wrnblocks *
+ rwb->blocksize]);
+ if (nread < 0 || (size_t)nread != padblocks)
Review Comment:
remove too
##########
drivers/misc/rwbuffer.c:
##########
@@ -164,13 +175,17 @@ static void rwb_wrflush(FAR struct rwbuffer_s *rwb)
ret = rwb->wrflush(rwb->dev, rwb->wrbuffer, rwb->wrblockstart,
rwb->wrnblocks);
- if (ret != rwb->wrnblocks)
+ if (ret < 0 || (size_t)ret != rwb->wrnblocks)
Review Comment:
remove the cast too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
