anchao commented on PR #20686: URL: https://github.com/apache/nuttx/pull/20686#issuecomment-6487811997
@chengkai15 Thanks for the clarification. I think we are mostly aligned on the long-term direction, especially about converging to one Zephyr-based Bluetooth host and moving toward a BlueZ/Linux-style split for protected/kernel builds. For open point 2, I still prefer not to start from an external repository model in the main NuttX integration path. My suggestion is that the code should first be adapted into a NuttX-native integration style, and then submitted directly to either nuttx.git or nuttx-apps.git, depending on the agreed layering. Fetching a large external repository at build time will also bring dependency and maintenance issues with other third-party code, and I do not think that is the best long-term integration model for an official NuttX Bluetooth stack. In my view, if the stack is going to become part of the NuttX Bluetooth architecture, it should be reviewed, built, tested, and maintained as part of the NuttX repositories, not as an external component that is only pinned by revision. Maybe you can use the current PR as a reference for the NuttX-native integration structure: top-level CONFIG_ZBLUE_ENABLED, NuttX build/Kconfig integration, NuttX-style public headers, and direct integration with the NuttX Bluetooth driver path. The implementation details can certainly be changed, but I think this kind of native integration is a better direction than relying on an external fetched repository. If the openvela version is adjusted in this direction and accepted by the community as the common upstream solution, I am willing to drop my current PR and help with that effort. My goal is not to keep my own patch, but to help NuttX get a complete and maintainable Bluetooth stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
