parthitce commented on PR #21088: URL: https://github.com/apache/nuttx/pull/21088#issuecomment-6500252050
> > ```shell > > from ./tc3xx/tc3xx_timerisr.c:35: > > illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/_PinMap/IfxScu_PinMap.h:39:10: fatal error: IfxScu_PinMap_TC39xB_LFBGA292.h: No such file or directory > > 39 | #include "IfxScu_PinMap_TC39xB_LFBGA292.h" > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > compilation terminated. > > In file included from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Scu/Std/IfxScuCcu.h:185, > > from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Std/IfxAsclin.h:50, > > from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Asc/IfxAsclin_Asc.h:233, > > from ./tc3xx/tc3xx_serial.c:46: > > illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/_PinMap/IfxScu_PinMap.h:39:10: fatal error: IfxScu_PinMap_TC39xB_LFBGA292.h: No such file or directory > > 39 | #include "IfxScu_PinMap_TC39xB_LFBGA292.h" > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > compilation terminated. > > ``` > > i revert my pr and have a test, infineon's illd github account change file name(tc39x change to tc39xB) and i will fix them, before my pr, it already have error for this error: revert might not help. But technically am not going in favour of this PR. yes for setjmp, sigsetjmp, longjmp, siglongjmp we need cover the CSA handling. Otherwise on the string and memory functions, compiler should emit the best versions? Why do we need a custom asm implementation in first place? > > > 39 | #include "IfxScu_PinMap_TC39xB_LFBGA292.h" > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > compilation terminated. > > In file included from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Scu/Std/IfxScuCcu.h:185, > > from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Std/IfxAsclin.h:50, > > from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Asc/IfxAsclin_Asc.h:233, > > from ./tc3xx/tc3xx_serial.c:46: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
