xiaoxiang781216 commented on code in PR #21140: URL: https://github.com/apache/nuttx/pull/21140#discussion_r4423567107
########## arch/arm/src/armv7-r/arm_syscall.c: ########## @@ -42,6 +43,22 @@ #include "sched/sched.h" #include "signal/signal.h" +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* From user mode, the only reserved system call that is allowed is the + * return from a signal handler that the kernel dispatched. Without full + * signal support the kernel dispatches no handler, so none is allowed. + */ + +#if defined(CONFIG_BUILD_PROTECTED) && defined(CONFIG_ENABLE_ALL_SIGNALS) +# define USER_SIGRETURN(tcb, cmd) \ + ((cmd) == SYS_signal_handler_return && (tcb)->xcp.sigreturn != 0) Review Comment: but why do we need this pr? if the global renumber will do. it's better to renumber it for arm in one pr and renumber arm64/riscv in the new pr by revert the old approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
