Fix-Point commented on PR #21342: URL: https://github.com/apache/nuttx/pull/21342#issuecomment-6756646464
> Commits [4023441](https://github.com/apache/nuttx/commit/40234415e83b327ab438253c3c7fe59c2de6edc8) to [b868ab9](https://github.com/apache/nuttx/commit/b868ab919b95282c484cead6808c1e1366eefba2) change the same lines one after the other: [f445687](https://github.com/apache/nuttx/commit/f4456873b8cbab8a1ed495e90310f18f68ef83dd) moves the DSB that [4023441](https://github.com/apache/nuttx/commit/40234415e83b327ab438253c3c7fe59c2de6edc8) adds, [bcc349e](https://github.com/apache/nuttx/commit/bcc349e5e70b5d2fe7dec2e955e5831b09b43119) adds `SPINWAIT_NOP` and [b868ab9](https://github.com/apache/nuttx/commit/b868ab919b95282c484cead6808c1e1366eefba2) removes it again, [4e40ab3](https://github.com/apache/nuttx/commit/4e40ab34a3faf7377c1b839706bf5424527f3835) replaces the x86_64 `UP_WFE()` that [4023441](https://github.com/apache/nuttx/commit/40234415e83b327ab438253c3c7fe59c2de6edc8) starts to use. The previous push had them as one commit, as xiaoxiang781216 asked. Fix: squash [4023441](htt ps://github.com/apache/nuttx/commit/40234415e83b327ab438253c3c7fe59c2de6edc8)..[b868ab9](https://github.com/apache/nuttx/commit/b868ab919b95282c484cead6808c1e1366eefba2) into one commit. Thanks for the review. I have squashed my own follow-up commits as suggested: the lock wait policy work now lands in a single commit, with the `UP_SPIN_RELAX()` hook commit reordered before it, so the add-then-modify churn between them is gone. One request we'd like to keep as-is: `4023441` (the WFE/SEV patch) is contributed by a colleague and we would prefer not to squash our refinements into his patch — keeping it standalone preserves the original authorship and keeps that change reviewable on its own. The remaining overlap with it (the DSB relocation in `f445687`) is a deliberate follow-up refinement rather than churn from the same work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
