zyfeier opened a new pull request, #21608:
URL: https://github.com/apache/nuttx/pull/21608

   ## Summary
   
     * Why: TASKING cctc does not support the `-x c` command line flag, so the
       make-flow allsyms link cannot compile the generated allsyms file with
       the TASKING toolchain.
     * What: the generated allsyms file is named `allsyms.c` instead of
       `allsyms.tmp`, and the explicit `-x c` language flag is dropped from the
       COMPILE invocation - the `.c` extension lets every compiler identify the
       language on its own.
     * How: this only touches the LINK_ALLSYMS rule in 
arch/tricore/src/Makefile;
       the CMake flow already generates `.c` allsyms sources
       (cmake/nuttx_multiple_link.cmake), so this also aligns the make flow with
       the CMake flow.
   
   ## Impact
   
     * Is new feature added? Is existing feature changed? YES - the make-flow
       allsyms link becomes toolchain-agnostic.
     * Impact on user (will user need to adapt to change)? NO
     * Impact on build (will build process change)? NO - same file content,
       different temporary filename.
     * Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO
     * Impact on documentation (is update required / provided)? NO
     * Impact on security (any sort of implications)? NO
     * Impact on compatibility (backward/forward/interoperability)? NO
   
   ## Testing
   
     I confirm that changes are verified on local setup and works as intended:
     * Build Host(s): Linux x86_64, tricore-elf-gcc 11.3.1 / TASKING SmartCode
       cctc v10.4, CMake 3.28.3 + Ninja
     * Target(s): triboard_tc4x9_com:nsh_allsyms (GNU make with
       CONFIG_ALLSYMS=y, exercises the changed link path),
       a2g-tc397-5v-tft:nsh (GNU make), triboard_tc4x9_com:nsh_tasking
       (TASKING CMake/Ninja)
   
     Runtime testing is not applicable: build-system-only change.
   
     Testing logs (triboard_tc4x9_com:nsh_allsyms, GNU make, CONFIG_ALLSYMS=y):
   
     ```
     CC:  allsyms.c
     LD: nuttx
     ```
   
     Testing logs (a2g-tc397-5v-tft:nsh, GNU make):
   
     ```
     LD: nuttx
     ```
   
     Testing logs (triboard_tc4x9_com:nsh_tasking, TASKING CMake/Ninja):
   
     ```
     ltc I402: activating file producing phase
     ltc I433: emitting object files (task1)
     ltc I434: emitting report files (task1)
     ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to