yangsong8-a1 opened a new pull request, #21620:
URL: https://github.com/apache/nuttx/pull/21620

   ## Summary
   include/nuttx/fs/fs.h includes <nuttx/fs/uio.h>, but it only uses
   struct uio behind a pointer and already forward-declares it. Since fs.h is
   reached from <stdio.h> and nuttx/sched.h, the full definition of struct uio
   ends up in nearly every file. struct uio is also a BSD name, so ported BSD
   code that defines its own (usrsctp, for example) does not build.
   
   - Fix the existing nxstyle errors in loop.c and fs_uio.c touched below
     (whitespace only)
   - Drop the include from fs.h and include <nuttx/fs/uio.h> in the eight
     files that use the definition or the uio_*() helpers
   
   ## Impact
   Build only. No functional change. Out-of-tree code that uses the members
   of struct uio or the uio_*() helpers through nuttx/fs/fs.h has to include
   <nuttx/fs/uio.h>.
   
   ## Testing
   Ubuntu 22.04, gcc 13.1, arm-none-eabi-gcc, aarch64-none-elf-gcc. The
   nxstyle commit was checked to leave the token stream of each file
   unchanged. Built with tools/configure.sh and make:
   
   - sim:nsh, sim:usbdev, sim:mnemofs, sim:alsa (CONFIG_DEV_LOOP)
   - qemu-armv8a:nsh, qemu-armv8a:rpserver
   - stm32f4discovery:nsh, spresense:rndis
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to