yangsong8-a1 opened a new pull request, #4011:
URL: https://github.com/apache/nuttx-apps/pull/4011

   ## Summary
   LVGL's src/drivers/nuttx/lv_nuttx_image_cache.c calls gettid() but only
   includes nuttx/mm/mm.h. It builds today only because NuttX headers pull in
   unistd.h indirectly (nuttx/mm/mm.h -> nuttx/userspace.h -> pthread.h ->
   unistd.h). apache/nuttx#21607 removes pthread.h from nuttx/userspace.h,
   and then the file fails with "implicit declaration of function 'gettid'".
   
   Add 0002-nuttx-image_cache-include-unistd.h.patch for LVGL 9.2.2 to include
   unistd.h explicitly, and let the Make and CMake builds apply a list of
   patches instead of a single one.
   
   ## Impact
   Build only. Applies to the default LVGL 9.2.2 archive, same as the
   existing 0001 patch. Git checkouts of LVGL are not modified.
   
   ## Testing
   Ubuntu 22.04, gcc 13.1. With apache/nuttx#21607:
   
   - Without this patch, sim:lvgl_fb reports implicit declaration of gettid()
     in lv_nuttx_image_cache.c
   - With this patch, sim:lvgl_fb, sim:lvgl_lcd and sim:baromonitor build
     with make, and sim:lvgl_fb builds with CMake, without the warning. Both
     patches are applied in both builds
   - Touching a patch file makes the CMake build and the lvgl context target
     re-unpack and re-patch the archive
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to