acassis commented on code in PR #21638:
URL: https://github.com/apache/nuttx/pull/21638#discussion_r4532315348
##########
drivers/can/ctucanfd_pci.c:
##########
@@ -1170,10 +1182,19 @@ static int ctucanfd_sock_transmit(FAR struct
netdev_lowerhalf_s *dev,
ctucanfd_putreg(priv, offset + CTUCANFD_TXBUF_TSL, 0);
ctucanfd_putreg(priv, offset + CTUCANFD_TXBUF_TSU, 0);
- for (i = 0; i < frame->can_dlc; i++)
+ /* Pack bytes into aligned register writes and pad the final word. */
+
+ for (i = 0; i < frame->can_dlc; i += 4)
Review Comment:
@szafonimateusz-mi please double check: ctucanfd never check if can_dlc > 8,
only kvaser do it. I noticed you didn't use AI for this PR, it could explain
why the (possible) issue happened :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]