zhangyu-duck commented on code in PR #21519: URL: https://github.com/apache/nuttx/pull/21519#discussion_r4533025277
########## arch/tricore/src/illd/tc4xx/Configurations/Ifx_Cfg_Ssw.h: ########## @@ -78,4 +78,12 @@ #define IFX_CFG_SSW_ENABLE_KEYOFF_MBIST_DSPRS_DMARAM (0U) Review Comment: ditto ########## arch/tricore/src/illd/tc3xx/Configurations/Ifx_Cfg_Ssw.h: ########## @@ -83,14 +83,14 @@ extern void Ifx_Ssw_Monbist(void); #endif #if IFX_CFG_SSW_ENABLE_PLL_INIT == 1U -#include "IfxScuCcu.h" Review Comment: without illd, why change illd code? ########## arch/tricore/src/common/tricore_stm.h: ########## @@ -0,0 +1,80 @@ +/**************************************************************************** + * arch/tricore/src/common/tricore_stm.h Review Comment: Try to avoid creating new files; couldn't this be placed in an existing .h or stm.c file instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
