casaroli opened a new pull request, #21687: URL: https://github.com/apache/nuttx/pull/21687
## Summary Since #21652, `FS_PROCFS` depends on `!DISABLE_MOUNTPOINT`. Seven options that can only be set together with `FS_PROCFS` still had their own `!DISABLE_MOUNTPOINT` term, which has no effect now: - fs/procfs/Kconfig, inside `if FS_PROCFS`: `FS_PROCFS_EXCLUDE_BLOCKS`, `FS_PROCFS_EXCLUDE_MOUNT`, `FS_PROCFS_EXCLUDE_MOUNTS`, `FS_PROCFS_EXCLUDE_USAGE`. - arch Kconfig files, `depends on ... FS_PROCFS && FS_PROCFS_REGISTER`: `STM32_CCM_PROCFS` (arch/arm/src/common/stm32/Kconfig.memory), `GD32F4_TCM_PROCFS` (arch/arm/src/gd32f4/Kconfig), `S32K1XX_RESETCAUSE_PROCFS` (arch/arm/src/s32k1xx/Kconfig). This PR removes the seven terms. The other `DISABLE_MOUNTPOINT` terms in Kconfig files are not about procfs and stay. ## Impact - No change to any configuration: the `.config` after `make olddefconfig` is the same before and after this PR (see Testing). No code changes. - Documentation/ does not name these dependencies, so there is no documentation change. ## Testing `./tools/configure.sh` + `kconfig-tweak` + `make olddefconfig` with the Kconfig files of master 03aea786390 and of this PR, then `diff` of the two `.config` files. All 11 are identical: | Configuration | Options set in the result | |---|---| | sim:nsh | FS_PROCFS | | qemu-armv8a:nsh | FS_PROCFS, FS_PROCFS_REGISTER | | qemu-armv8a:nsh + DISABLE_MOUNTPOINT=y | DISABLE_MOUNTPOINT (no FS_PROCFS*) | | qemu-armv8a:nsh + the four FS_PROCFS_EXCLUDE_* options | FS_PROCFS, the four options | | nucleo-f072rb:nsh | FS_PROCFS | | stm32f4discovery:nsh + FS_PROCFS_REGISTER + STM32_CCM_PROCFS | FS_PROCFS, FS_PROCFS_REGISTER, STM32_CCM_PROCFS | | the same + DISABLE_MOUNTPOINT=y | DISABLE_MOUNTPOINT (STM32_CCM_PROCFS removed in both) | | gd32f450zk-eval:netnsh + GD32F4_TCM_PROCFS | FS_PROCFS, FS_PROCFS_REGISTER, GD32F4_TCM_PROCFS | | the same + DISABLE_MOUNTPOINT=y | DISABLE_MOUNTPOINT (GD32F4_TCM_PROCFS removed in both) | | s32k146evb:nsh + FS_PROCFS, FS_PROCFS_REGISTER, S32K1XX_RESETCAUSE_PROCFS | the three options | | the same + DISABLE_MOUNTPOINT=y | DISABLE_MOUNTPOINT (S32K1XX_RESETCAUSE_PROCFS removed in both) | stm32f4discovery:nsh with `FS_PROCFS_REGISTER` and `STM32_CCM_PROCFS` builds with no warnings (`EXTRAFLAGS="-Wno-cpp -Werror"`, arm-none-eabi-gcc 15.3). `tools/checkpatch.sh -c -u -m -g origin/master..HEAD` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
