arnavsharma990 commented on PR #21391: URL: https://github.com/apache/nuttx/pull/21391#issuecomment-6790943236
Thanks for the review @c'! I've addressed the attribute modification path as well. `fat_attrib()` now returns `-EROFS` when `setbits` or `clearbits` is non-zero and `CONFIG_FS_FAT_READONLY` is enabled, while attribute queries remain supported. I've also updated the PR title and description to reflect the current implementation and validation results. Both writable and read-only configurations build successfully. Runtime smoke tests confirm that read-only FAT rejects file creation, deletion, directory creation, and truncation attempts. The writable configuration was also tested successfully for basic file and directory operations. The read-only build reduces `__TEXT` by 16,384 bytes, and linker symbol comparison confirms that `fat_write` and `fat_truncate` are eliminated. Additional runtime checks, including `fsync()`, attribute modification, and image-hash verification, remain untested. Thanks for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
