Brijesh-Thakkar commented on PR #21537:
URL: https://github.com/apache/nuttx/pull/21537#issuecomment-6794093013

   **Updated after checking**: %k would be a new top-level format specifier 
that -Wformat from GCC fails for (fails CI with -Werror), so better do it as 
the current extensions do:
   Add %pq (pointer to a b16_t) in lib_vsprintf_internal(), alongside 
%pB/%pV/%pS, under LIBC_PRINT_EXTENSION. It passes -Wformat and width/precision 
are implemented there.
   %pq in lib_bsprintf/lib_bscanf is treated as 4 bytes of a b16_t member. The 
scanning remains in the bformat part only, so sscanf() and %hf stay the same.
   None selected from the kernel: UORB_FORMAT in apps selects 
LIBC_PRINT_EXTENSION already.
   format macro for sensor_data_t members ("hf" or "pq") goes into 
include/nuttx/uorb.h and used by the apps sensor formatters in a separate PR.
   PR #21521 and #21576 are merged, so there will be only the above in this PR. 
OK to change this PR accordingly? 
   Any other letter than q?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to