xiaoxiang781216 commented on code in PR #21733:
URL: https://github.com/apache/nuttx/pull/21733#discussion_r4543365066
##########
libs/libc/time/lib_localtime.c:
##########
@@ -525,32 +530,51 @@ static void scrub_abbrs(struct state_s *sp)
}
}
+static void update_tzname(FAR struct state_s *sp,
+ FAR const struct ttinfo_s *ttisp)
+{
+ tzname[ttisp->tt_isdst] = &sp->chars[ttisp->tt_desigidx];
+ if (ttisp->tt_isdst)
+ {
+ daylight = 1;
+ }
+ else
+ {
+ timezone = -ttisp->tt_utoff;
+ }
+}
+
static void settzname(void)
{
FAR struct state_s * const sp = g_lcl_ptr;
int i;
tzname[0] = tzname[1] = (FAR char *)g_wildabbr;
+ daylight = 0;
Review Comment:
move after line 556
##########
libs/libc/unistd/lib_domainname.c:
##########
@@ -0,0 +1,125 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_domainname.c
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <errno.h>
+#include <limits.h>
+#include <string.h>
+#include <unistd.h>
+
+#include <nuttx/irq.h>
+#include <nuttx/spinlock.h>
+
+/* The domain name is a system property, as the host name is. In the
+ * protected and kernel builds it is kept only in the kernel, and user
+ * space calls these functions through system calls.
+ */
+
+#if defined(CONFIG_BUILD_FLAT) || defined(__KERNEL__)
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static char g_domainname[HOST_NAME_MAX + 1];
Review Comment:
why not move to task_tls and make it always a userspace function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
