Fix-Point opened a new pull request, #4033: URL: https://github.com/apache/nuttx-apps/pull/4033
Depends-On: https://github.com/apache/nuttx/pull/21764 ## Summary This PR updates ostest's `wdtest_assert()` to capture its argument as literal text. `wdtest_assert(x)` forwarded `x` to `_ASSERT(x, __FILE__, __LINE__)`, whose `#f` stringified the argument after the `wdtest_assert -> _ASSERT` chain had already macro-expanded it. Passing the stringified argument from `wdtest_assert` itself (via `_ASSERT_STR`) keeps the assert message as the literal expression text instead of an expanded macro tree. This is the apps-side companion to the NuttX change "include/assert: stringify assert expressions at the first macro level" (which introduces `_ASSERT_STR()`). ## Impact - User: none — `wdtest_assert` reports the literal assertion text; no behavior change (the condition is evaluated exactly as before). - Build: no config or build-system change. - Compatibility: requires `_ASSERT_STR()` from the NuttX PR above (hence Depends-On); the change is one macro definition in ostest. - Security: no change. ## Testing - Covered by the NuttX-side verification of the stringification behavior (qemu-intel64, `CONFIG_DEBUG_ASSERTIONS_EXPRESSION=y`: assert strings hold the source text, no large strings in the image). - The ostest wdog tests exercise `wdtest_assert`; the change is a macro-level stringification fix with no behavior difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
