txy-21 opened a new pull request, #21792:
URL: https://github.com/apache/nuttx/pull/21792
## Summary
* include/nuttx/wqueue.h declares lpwork_restorepriority() only when
both CONFIG_SCHED_LPWORK and CONFIG_PRIORITY_INHERITANCE are defined,
but aio_fsync_worker() called it whenever CONFIG_PRIORITY_INHERITANCE
was defined.
* Changed part: fs/aio/aio_fsync.c, the priority restore at the end of
aio_fsync_worker().
* How it works: the call now uses the condition of the declaration.
* Related NuttX issue: none.
* Related NuttX Apps issue/PR: none.
## Impact
* Is new feature added? NO
* Is existing feature changed? NO - in every configuration that builds
today the call is compiled as before, and nothing changes at runtime.
* Impact on user? NO
* Impact on build? NO
* Impact on hardware? NO
* Impact on documentation? NO
* Impact on security? NO
* Impact on compatibility? NO
* Anything else to consider or add? The same condition mismatch is
still present in aio_queue.c, aio_read.c and aio_write.c; it is not
changed here.
## Testing
I confirm that changes are verified on local setup and works as intended:
* Target(s): sim:citest (x86_64 simulator), CONFIG_FS_AIO=y
Testing logs before change:
```
Not captured: this is a compile-time guard, and the configurations that
build today behave identically before and after.
```
Testing logs after change:
```
nsh> uname -a
NuttX 0.0.0 0b5a53e9d5 Nov 12 2026 20:03:54 sim sim
nsh> poweroff
```
fs/aio/aio_fsync.c was compiled in this build (`CC: aio/aio_fsync.c`),
with no warnings and no errors.
Not tested:
* A configuration with CONFIG_PRIORITY_INHERITANCE=y and
CONFIG_SCHED_LPWORK=n was not built. The same call pattern is still
present in aio_queue.c, aio_read.c and aio_write.c, so such a
configuration is expected to fail there first.
* Protected and kernel builds.
* Real hardware and other architectures.
## PR verification Self-Check
* [ ] This PR introduces only one functional change.
* [ ] I have updated all required description fields above.
* [ ] My PR adheres to Contributing Guidelines and Documentation (git
commit title and message, coding standard, etc).
* [ ] My PR is still work in progress (not ready for review).
* [ ] My PR is ready for review and can be safely merged into a codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]