darrylring commented on code in PR #21814:
URL: https://github.com/apache/nuttx/pull/21814#discussion_r4557018707


##########
arch/arm/src/common/stm32/stm32_capture_m3m4_v1.c:
##########
@@ -1202,26 +1191,18 @@ static uint32_t stm32_cap_getcapture(struct 
stm32_cap_dev_s *dev,
       case STM32_CAP_CHANNEL_COUNTER:
         offset = STM32_GTIM_CNT_OFFSET;
         break;
-#ifdef HAVE_CH1IN
       case 1:

Review Comment:
   Hmm, good point. Building the `nucleo-h563zi:capture` config...
   
   Before (unoptimized, full optimization)
   
   ```
   Memory region         Used Size  Region Size  %age Used
              flash:      252852 B         2 MB     12.06%
               sram:       10032 B       256 KB      3.83%
   
   Memory region         Used Size  Region Size  %age Used
              flash:      156284 B         2 MB      7.45%
               sram:       10024 B       256 KB      3.82%
   ```
   
   After  (unoptimized, full optimization)
   
   ```
   Memory region         Used Size  Region Size  %age Used
              flash:      252924 B         2 MB     12.06%
               sram:       10032 B       256 KB      3.83%
   
   Memory region         Used Size  Region Size  %age Used
              flash:      156284 B         2 MB      7.45%
               sram:       10024 B       256 KB      3.82%
   
   
   ```
   
   It's a 72 byte increase in code size in an unoptimized build, but seems to 
have no impact with full optimization on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to