Shanks0224 opened a new pull request, #4049: URL: https://github.com/apache/nuttx-apps/pull/4049
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Two changes that the PSE52 conformance fixes in apache/nuttx need: * testing/ostest: the cancel test destroys a condition variable after its waiter was cancelled. With the nuttx change, `pthread_cond_destroy()` returns EBUSY while a thread is counted as a waiter, so broadcast the condition before it is destroyed. * benchmarks/cyclictest: the `-c` option used the number from the user as the clock ID. Map 0 and 1 to `CLOCK_REALTIME` and `CLOCK_MONOTONIC`, as the help text and the documentation say, so that the option keeps working when the clock ID values change. Both commits also fix the nxstyle errors in the files that they touch. Related: apache/nuttx#XXXX ## Impact None for users. Both changes also work with the current nuttx, so this PR can be merged first. ## Testing * ostest, `sim:ostest`, 5 loops: passes with the current nuttx master, and with the nuttx PR above. With the nuttx PR it also passes on `qemu-armv7r:pnsh`, `qemu-armv7a:knsh` and a B-L475E-IOT01A board (`b-l475e-iot01a:nsh` with `CONFIG_TESTING_OSTEST=y`). The cancel test with the nuttx PR: ``` restart_thread: Broadcasting cond to clear waiters restart_thread: Destroying cond ``` * cyclictest, `sim:nsh` with `CONFIG_TIMER=y` and `CONFIG_BENCHMARK_CYCLICTEST=y`: `cyclictest -c 0 -l 200` and `cyclictest -c 1 -l 200` run with the current nuttx master and with the nuttx PR: ``` nsh> cyclictest -c 0 -l 200 T: 0 ( 9) P: 1 I:1000 C: 10 Min: 8863 Act: 8972 Avg: 8982 Max: 9036 ``` The output does not show which clock is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
