xiaoxiang781216 commented on code in PR #21845:
URL: https://github.com/apache/nuttx/pull/21845#discussion_r4564586198


##########
arch/arm64/src/Toolchain.defs:
##########
@@ -268,7 +268,13 @@ ifeq ($(CONFIG_ARCH_TOOLCHAIN_GCC),y)
   ifeq ($(GCCVER),)
     export GCCVER := $(shell $(CC) --version | grep gcc | sed -E "s/.* 
([0-9]+\.[0-9]+).*/\1/" | cut -d'.' -f1)
   endif
-  ifeq ($(shell expr "$(GCCVER)" \>= 12), 1)

Review Comment:
   can we use make built-in compare operator directly? instead exposing more 
the computation result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to