ShubhamTaple opened a new pull request, #21860:
URL: https://github.com/apache/nuttx/pull/21860

   ### **Summary of change:**
   MPFS_CAN_ACR_AMR_ID in hardware/mpfs_can.h is defined as (0x1fffffff << 
MPFS_CAN_RX_MSG_AMR_ID_SHIFT), but MPFS_CAN_RX_MSG_AMR_ID_SHIFT does not exist 
anywhere in the tree. The intended symbol is the adjacent 
MPFS_CAN_ACR_AMR_ID_SHIFT (3), which matches the documented layout: the 29-bit 
identifier occupies bits 31:3, with IDE at bit 2 and RTR at bit 1. This is 
exactly what the existing comment /* Identifier bits [31:3] */ states.
   
   ### **Impact:** 
   None. MPFS_CAN_ACR_AMR_ID is not referenced by any code (verified with grep 
-rn), so this is a latent correctness fix with no behavioral change. Introduced 
in #17161.
   
   ### **Testing:** 
   N/A — macro is unused; header-only change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to