DawnLiu66 opened a new pull request, #21919:
URL: https://github.com/apache/nuttx/pull/21919

   ## Summary
   
   `register_driver_with_size()` calls `sched_note_mark(NOTE_TAG_DRIVERS, ...)`
   directly, so the mark is emitted whenever note dump is enabled and ignores
   `CONFIG_TRACE_DRIVERS`. Use `drivers_trace_mark()` like
   `drivers_initialize()` does, so the tracepoint follows the drivers trace
   option.
   
   ## Impact
   
   - New feature: NO.
   - User adaptation: NO.
   - Build: NO.
   - Hardware: NO.
   - Documentation: NO.
   - Security: NO.
   - Compatibility: with `CONFIG_SCHED_INSTRUMENTATION_DUMP` but without
     `CONFIG_TRACE_DRIVERS`, `register_driver()` no longer emits a note mark.
   
   ## Testing
   
   I confirm that changes are verified on local setup and works as intended:
   
   - Build Host: Ubuntu 22.04 x86_64, gcc (Ubuntu 13.1.0-8ubuntu1~22.04) 13.1.0,
     master `a3b67d70e0`.
   - Target: `sim:nsh` with `CONFIG_SCHED_INSTRUMENTATION`,
     `CONFIG_SCHED_INSTRUMENTATION_DUMP`, `CONFIG_DRIVERS_NOTERAM`, 
`CONFIG_TRACE`
     and `CONFIG_TRACE_DRIVERS`. Verified on sim only, no real hardware.
   - `./tools/checkpatch.sh -m -g master..HEAD`: all checks pass.
   - Make and CMake builds pass, `ostest` exits with status 0.
   
   ## PR verification Self-Check
   
   * [x] This PR introduces only one functional change.
   * [x] I have updated all required description fields above.
   * [x] My PR adheres to Contributing Guidelines and Documentation (git commit 
title and message, coding standard, etc).
   * [ ] My PR is still work in progress (not ready for review).
   * [x] My PR is ready for review and can be safely merged into a codebase.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to