Kaben123 opened a new pull request, #21923:
URL: https://github.com/apache/nuttx/pull/21923

   ## Summary
   
   `ramlog_file_read()` asserted `!up_interrupt_context()` because it may block
   waiting for new data. That prevents reading the buffered log from an 
interrupt
   or crash handler, where dumping the recent log is most useful.
   
   The assertion is removed. In interrupt context the reader no longer waits: 
when
   the buffer becomes empty it returns what has been copied so far.
   
   ## Impact
   
   Behavior in thread context is unchanged. Reading from interrupt context, 
which
   used to assert, now returns the available data without blocking.
   
   ## Testing
   
   Host: Ubuntu 22.04 x86_64, GCC 13.1.0. Base: apache/nuttx master 
5c1746778e8, apache/nuttx-apps master 7f4e5382d.
   
   - `sim:nsh` + `CONFIG_RAMLOG=y`, `CONFIG_RAMLOG_SYSLOG=y`: builds without
     warnings (CMake and Make), `dmesg` works as before.
   - `tools/checkpatch.sh -c -u -m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to