xiaoxiang781216 commented on code in PR #21865: URL: https://github.com/apache/nuttx/pull/21865#discussion_r4597596279
########## boards/risc-v/qemu-rv/rv-virt/scripts/Make.defs: ########## @@ -63,3 +63,11 @@ endef endif endif endif + +ifeq ($(CONFIG_RUSTSBI),y) Review Comment: move to rustsbi makefile, or generalize it to support other sbi ########## boards/risc-v/qemu-rv/rv-virt/CMakeLists.txt: ########## @@ -22,6 +22,16 @@ add_subdirectory(src) +if(CONFIG_RUSTSBI) Review Comment: ditto ########## arch/risc-v/src/sbi/rustsbi/Kconfig: ########## @@ -0,0 +1,18 @@ +if RUSTSBI Review Comment: should we move if check to parent Kconfig like make file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
