xiaoxiang781216 commented on code in PR #21910:
URL: https://github.com/apache/nuttx/pull/21910#discussion_r4604613059
##########
audio/audio.c:
##########
@@ -89,6 +89,7 @@ struct audio_upperhalf_s
{
struct audio_info_s info; /* Record the last playing audio
format */
mutex_t lock; /* Supports mutual exclusion */
+ mutex_t mqlock; /* Keeps the opens for a thread that
sends */
Review Comment:
why not reuse lock?
##########
audio/audio.c:
##########
@@ -1573,11 +1582,22 @@ static inline void audio_sendmsg(FAR struct
audio_upperhalf_s *upper,
FAR struct audio_openpriv_s *priv;
pollevent_t eventset;
irqstate_t flags;
+ bool intr = up_interrupt_context();
+
+ /* In a thread, file_mq_send() can wait for room in a full queue and can
Review Comment:
should we change mq to nonblocking mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]