JianyuWang0623 commented on code in PR #4077:
URL: https://github.com/apache/nuttx-apps/pull/4077#discussion_r4608396890


##########
system/nxinit/Kconfig:
##########
@@ -28,6 +28,17 @@ config SYSTEM_NXINIT_PROGNAME
        string "Program name"
        default "init"
 
+config SYSTEM_NXINIT_UMASK
+       string "File mode creation mask"
+       default ""

Review Comment:
   Kconfig has no octal type, and a umask is conventionally written as an octal 
string (chmod, toybox, busybox, Android init and systemd all parse it that way).
   > - Linux chmod (coreutils + gnulib): 
https://github.com/coreutils/gnulib/blob/master/lib/modechange.c#L146-L152
   > - toybox chmod (Android): 
https://github.com/landley/toybox/blob/master/lib/lib.c#L948-L949
   > - busybox chmod: 
https://github.com/mirror/busybox/blob/master/libbb/parse_mode.c#L47-L48
   > - Android init: 
https://android.googlesource.com/platform/system/core/+/refs/heads/main/init/builtins.cpp#1004
   > - systemd UMask=: 
https://github.com/systemd/systemd/blob/main/src/basic/parse-util.c#L96-L104



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to