xiaoxiang781216 commented on code in PR #21942: URL: https://github.com/apache/nuttx/pull/21942#discussion_r4609256214
########## arch/x86_64/src/intel64/intel64_rtc.c: ########## @@ -179,4 +210,236 @@ int up_rtc_settime(const struct timespec *tp) return OK; } + +#elif defined(CONFIG_RTC) + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +static uint8_t cmos_read(uint8_t reg) Review Comment: show we refactor intel64_rtc.c into rtc driver(include/nuttx/timers/rtc.h) and reuse drivers/timers/arch_rtc.c to implement up_rtc_xxx api? ########## arch/x86_64/src/intel64/intel64_rtc.c: ########## @@ -179,4 +210,236 @@ int up_rtc_settime(const struct timespec *tp) return OK; } + +#elif defined(CONFIG_RTC) + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +static uint8_t cmos_read(uint8_t reg) Review Comment: show we refactor intel64_rtc.c into rtc driver(include/nuttx/timers/rtc.h) and reuse drivers/timers/arch_rtc.c to implement up_rtc_xxx api by new pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
